Merged
Conversation
🦋 Changeset detectedLatest commit: 4982e7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Coverage Report for Coverage
File Coverage
|
||||||||||||||||||||||||||||||||||||||
tomiir
reviewed
Nov 19, 2024
| availableToSwap: | ||
| caipAddress && !invalidToToken && !invalidSourceToken && !invalidSourceTokenAmount, | ||
| isAuthConnector: type === 'AUTH' | ||
| isAuthConnector: type === 'ID_AUTH' |
Collaborator
There was a problem hiding this comment.
was 'AUTH' stil a valid type?
Contributor
Author
There was a problem hiding this comment.
AUTH and ID_AUTH shares the type: ConnectorType
authConnectorId = ID_AUTH
authConnectorType = AUTH
This is confusing, so we should definitely improve this
0xmkh
reviewed
Nov 19, 2024
| availableToSwap: | ||
| caipAddress && !invalidToToken && !invalidSourceToken && !invalidSourceTokenAmount, | ||
| isAuthConnector: type === 'AUTH' | ||
| isAuthConnector: type === 'ID_AUTH' |
Collaborator
There was a problem hiding this comment.
Should we maybe add ID_AUTH to a constants file ?
Collaborator
There was a problem hiding this comment.
this should be type checked already else it'd say that it would always be false 🤔
but we should use the constant regardless IMO
0xmkh
approved these changes
Nov 19, 2024
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hotfix: fix broken state swaps
Type of change
Associated Issues
Closes APKT-xxx
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist